Add to Travis-CI#59
Conversation
|
I don't, I've never really worked with Travis and sort of accepted on blind faith a .travis.yml file given to me for the gem :) |
|
Would you be open to setting up travis for this project too? I'll add the configs if so. |
|
Sure! |
|
OK... I've attached some code that adds a Travis config file. The build doesn't pass yet because the tests don't pass without having run Furthermore, the JRuby build is failing because it can't migrate without raising an exception. This seems to be a problem with activerecord-jdbc-adapter v1.2.5. The comment in the @RISCfuture, do you know if the problem is also in v1.2.7? If so, v1.2.2 works, but I'm not sure if this causes other problems for you. |
|
Ah, according to jruby/activerecord-jdbc-adapter#322 and the README, v1.2.7 should address the concern which is alluded to in the |
1.2.7 fixes the bind bug/vulnerability that was in 1.2.6. See jruby/activerecord-jdbc-adapter#322
2 participants
I noticed that the ruby gem is on travis, but this is not. Ideally, it'd be great to have https://travis-ci.org/SquareSquash/web check on PR statuses. I'd like to add some tests for testing WAR building (as part of #57) so having it run in JRuby as well as MRI (and maybe Rubinius, etc) would be great.
I'm happy to add a
.travis.ymlfile if you don't have one you already use.